Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups #80

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Groups #80

wants to merge 25 commits into from

Conversation

hel0t
Copy link

@hel0t hel0t commented Jul 3, 2024

Adds:

  • Create, Join, Leave, Disband, Transfer group functionality
  • Create, Decline group membership invites
  • Raid invite, raid ready, auto-join group leader when joining raid
  • Allow scavs to play on PMC host games & vice versa
  • Allow other squads to join host and spawn in different locations

@Lacyway Lacyway self-requested a review July 3, 2024 04:28
@Lacyway
Copy link
Member

Lacyway commented Jul 3, 2024

Very excited to read through and test this.

However, from a quick glance it does not conform to our code standards (see CONTRIBUTING) and has a lot of unmotivated changes. I will code review it as soon as I can. Has this been tested with the NAT punching as well?

And great job! Thanks.

@hel0t
Copy link
Author

hel0t commented Jul 3, 2024

No worries I'll take a look at the standards a bit later and get it up to scratch. Haven't tested with NAT punching but will give it a shot.

Server updates not far behind so you'll be able to play with it all

@Lacyway
Copy link
Member

Lacyway commented Jul 3, 2024

Perfect, thank you.
Are you on our Discord? If so, could you throw me a DM?

Copy link
Member

@Lacyway Lacyway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but some changes are required before merging and I also have some concerns that needs to be addressed.

Fika.Core/Coop/Components/CoopHandler.cs Outdated Show resolved Hide resolved
Fika.Core/Coop/GameMode/CoopGame.cs Outdated Show resolved Hide resolved
Fika.Core/Coop/GameMode/CoopGame.cs Outdated Show resolved Hide resolved
Fika.Core/Coop/GameMode/CoopGame.cs Show resolved Hide resolved
Fika.Core/Coop/GameMode/CoopGame.cs Outdated Show resolved Hide resolved
Fika.Core/Networking/FikaServer.cs Outdated Show resolved Hide resolved
Fika.Core/Networking/FikaServer.cs Outdated Show resolved Hide resolved
Fika.Core/UI/Custom/MatchMakerUIScript.cs Outdated Show resolved Hide resolved
Fika.Core/UI/Custom/MatchMakerUIScript.cs Show resolved Hide resolved
@hel0t hel0t force-pushed the 3.9-groups branch 8 times, most recently from 5bea97c to 39eb0ef Compare July 4, 2024 01:14
@hel0t
Copy link
Author

hel0t commented Jul 4, 2024

Alrighty those changes have been made

@hel0t hel0t changed the base branch from 3.9-dev to main July 8, 2024 13:23
@Birgerev
Copy link

Birgerev commented Aug 5, 2024

@Lacyway anything holding this back atm?

@Lacyway
Copy link
Member

Lacyway commented Aug 5, 2024

@Lacyway anything holding this back atm?

It's severely outdated and I still haven't figured out how to bypass the hardcoded max players. I've asked the author to keep it so that we can try to implement it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants